-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pds sqlite refactor #1705
Merged
Merged
Pds sqlite refactor #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
reviewed
Oct 31, 2023
packages/pds/src/api/com/atproto/server/requestEmailConfirmation.ts
Outdated
Show resolved
Hide resolved
devinivy
reviewed
Oct 31, 2023
devinivy
reviewed
Oct 31, 2023
devinivy
reviewed
Oct 31, 2023
devinivy
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a good handful of notes and comments, but seriously wow 💎 tons of great simplifications in here and things feel very tidy.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the PDS to use a single-tenant SQLite datastore.
Each user has their own SQLite file that stores their repo and private account state.
User databases are stored hierarchically as such:
/${dbDirectory}/${sha256Hex(did).slice(0,2)}/${did}
Repo signing keys for each repo are stored alongside the SQLite file.
We also switch out the abstraction for interacting with user data to an
ActorStore
. The primary difference between theActorStore
and our previous "services" is that theActorStore
has different classes for reading & writing. Since SQLite does not support concurrent transactions, theActorStore
requires that you clearly "transact" with the store in order to make a write.We also maintain an LRUCache for signing keys and databases. We allow 30k open file handles and 30k keys held in memory. When a database falls out of the cache, we ensure that we close the file handle.
We also introduce 3 separate SQLite databases for managing service state:
Each of these SQLite files in run in WAL mode to allow for concurrent reads and streaming replication.
We intend to ship the PDS distribution with Litestream or something similar